37 create a basic intake subsystem #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/FRC-Team-620/Warbots2024 into 37-create-a-basic-intake-subsystem
Changed the IntakeCommand file with the information in last year's version. Added IntakeConstants file just to place contastant although can delete later.
m10653
requested changes
Jan 24, 2024
src/main/java/org/jmhsrobotics/frc2024/subsystems/drive/commands/IntakeConstants.java
Outdated
Show resolved
Hide resolved
Comment on lines
17
to
19
| protected Solenoid intakeArmsVirtualSolenoidB; | ||
| protected CANSparkMax intakeArmsMotor; |
There was a problem hiding this comment.
Our intake only will have a single motor. We probably will not have any pneumatics.
src/main/java/org/jmhsrobotics/frc2024/subsystems/drive/commands/IntakeCommand.java
Outdated
Show resolved
Hide resolved
| protected Solenoid intakeArmsVirtualSolenoidB; | ||
| protected CANSparkMax intakeArmsMotor; | ||
| protected DigitalInput intakeSwitch; |
Lu-han-wang
reviewed
Jan 25, 2024
src/main/java/org/jmhsrobotics/frc2024/subsystems/drive/commands/IntakeCommand.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will probably need more changes but want to check the situation so far.